Add flag --incompatible_use_plus_in_repo_names #23103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
Wyverald
force-pushed
the
wyv-repo-plus-flag
branch
from
fe0843b
to
2a9ecaf
Compare
Defaults to false. When set to true, we use `+` instead of `~` as the separator in canonical repo names. Some more subtle changes include: - We now officially say that the "build" part of version strings (the part that begins with a plus) is ignored and stripped. - When the flag is set to true, we effectively increase the lockfile version by 1 (see code comment in BazelLockFileModule). - When true, we no longer insert a `_main` in front of names of repos generated by module extensions hosted in the main repo. (`~abc` as a name was problematic, but `+abc` is not.) - When true, we no longer insert a `v` in front of numerical versions in canonical repo names. (`my_mod~1.1` could be a Windows short path, but `my_mod+1.1` cannot.) Work towards #22865.
Wyverald
force-pushed
the
wyv-repo-plus-flag
branch
from
2a9ecaf
to
4c1a50b
Compare
fmeum
reviewed
Jul 24, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelDepGraphValue.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelLockFileModule.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionId.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleKey.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleKey.java
Outdated
Show resolved
Hide resolved
Let's look at all printable non-alphanumeric ASCII characters:
So it looks like |
|
|
fmeum
approved these changes
Jul 25, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelLockFileModule.java
Show resolved
Hide resolved
meteorcloudy
approved these changes
Jul 26, 2024
|
@Wyverald Can you file an incompatible issue to track this change? https://github.com/bazelbuild/bazel/issues/new/choose |
5 tasks
github-actions
bot
removed
the
awaiting-review
|
@bazel-io fork 7.3.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jul 29, 2024
Defaults to false. When set to true, we use `+` instead of `~` as the separator in canonical repo names. Some more subtle changes include: - We now officially say that the "build" part of version strings (the part that begins with a plus) is ignored and stripped. - When the flag is set to true, we effectively increase the lockfile version by 1 (see code comment in BazelLockFileModule). - When true, we no longer insert a `_main` in front of names of repos generated by module extensions hosted in the main repo. (`~abc` as a name was problematic, but `+abc` is not.) - When true, we no longer insert a `v` in front of numerical versions in canonical repo names. (`my_mod~1.1` could be a Windows short path, but `my_mod+1.1` cannot.) Work towards bazelbuild#22865. Closes bazelbuild#23103. PiperOrigin-RevId: 657202616 Change-Id: I015b2a04a823b1d951015a1b2e1b99b154dcc5a2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Defaults to false. When set to true, we use `+` instead of `~` as the separator in canonical repo names. Some more subtle changes include: - We now officially say that the "build" part of version strings (the part that begins with a plus) is ignored and stripped. - When the flag is set to true, we effectively increase the lockfile version by 1 (see code comment in BazelLockFileModule). - When true, we no longer insert a `_main` in front of names of repos generated by module extensions hosted in the main repo. (`~abc` as a name was problematic, but `+abc` is not.) - When true, we no longer insert a `v` in front of numerical versions in canonical repo names. (`my_mod~1.1` could be a Windows short path, but `my_mod+1.1` cannot.) Work towards #22865. Closes #23103. PiperOrigin-RevId: 657202616 Change-Id: I015b2a04a823b1d951015a1b2e1b99b154dcc5a2 Commit 2f67e57 Co-authored-by: Xdng Yng <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
This PR essentially flips `--incompatible_use_plus_in_repo_names` (introduced in #23103) to true on master. In addition, it graveyards the flag, removes all logic to use `~`, and fixes all tests to use `+` instead. Closes #23098. RELNOTES: The format of canonical repo names has changed to use plus (`+`) instead of tilde (`~`). Effectively, this flips the flag `--incompatible_use_plus_in_repo_names` to true, and the flag is now a no-op (i.e. cannot be "unflipped"). PiperOrigin-RevId: 657913333 Change-Id: Ia97609049871db7a914fe3129556cf843d06f571
|
There was a slight, but I guess expected fallout, I had to switch some per_file_copt from to And because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to false. When set to true, we use
+instead of~as the separator in canonical repo names.Some more subtle changes include:
_mainin front of names of repos generated by module extensions hosted in the main repo. (~abcas a name was problematic, but+abcis not.)vin front of numerical versions in canonical repo names. (my_mod~1.1could be a Windows short path, butmy_mod+1.1cannot.)Work towards #22865.